Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC: eslint integration poc #36428

Draft
wants to merge 27 commits into
base: release
Choose a base branch
from
Draft

POC: eslint integration poc #36428

wants to merge 27 commits into from
+274 −56

Conversation

ayushpahwa
Copy link
Contributor

@ayushpahwa ayushpahwa commented Sep 19, 2024 •
edited by github-actions bot
Loading

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Warning

Tests have not run on the HEAD a293361 yet

Mon, 11 Nov 2024 07:54:58 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 19, 2024 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ayushpahwa ayushpahwa changed the title Feat/eslint integration feat:eslint integration Sep 19, 2024
@ayushpahwa ayushpahwa changed the title feat:eslint integration chore: eslint integration poc Sep 19, 2024
@github-actions github-actions bot added Enhancement New feature or request skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed Enhancement New feature or request labels Sep 19, 2024
@ayushpahwa
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10948402508.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36428.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-36428.dp.appsmith.com

@ayushpahwa
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10953860834.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36428.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-36428.dp.appsmith.com

@ayushpahwa
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11018448751.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36428.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-36428.dp.appsmith.com

@ayushpahwa
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11019318061.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36428.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-36428.dp.appsmith.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Oct 7, 2024
@github-actions GitHub Actions
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Oct 23, 2024
@ayushpahwa ayushpahwa reopened this Nov 6, 2024
@ayushpahwa ayushpahwa changed the title chore: eslint integration poc POC: eslint integration poc Nov 6, 2024
@github-actions github-actions bot removed the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Nov 6, 2024
@ayushpahwa
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11701556446.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 36428.
recreate: .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KelvinOm KelvinOm Awaiting requested review from KelvinOm KelvinOm will be requested when the pull request is marked ready for review KelvinOm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ayushpahwa